Read fee values from kvstore in the escrow contract#3812
Open
Read fee values from kvstore in the escrow contract#3812
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
dnechay
reviewed
Mar 4, 2026
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
Don't forget to add changesets
Dzeranov
reviewed
Mar 4, 2026
…ow contract - rename manifestUrl to manifest
dnechay
reviewed
Mar 5, 2026
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
lgtm in general, some minor questions
| # Restore full workspace dependencies after local runs to avoid breaking | ||
| # top-level commands like `yarn lint`. | ||
| if [[ -z "${CI:-}" ]]; then | ||
| yarn --cwd "$REPO_ROOT" install --mode=skip-build |
Collaborator
There was a problem hiding this comment.
Why skip-build? It might leave some top-level packages in a partial state after installation
Comment on lines
+1305
to
+1310
|
|
||
| try { | ||
| return await readManifestField('manifest'); | ||
| } catch { | ||
| return await readManifestField('manifestUrl'); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| try { | |
| return await readManifestField('manifest'); | |
| } catch { | |
| return await readManifestField('manifestUrl'); | |
| } | |
| if (typeof this.contract.manifest === 'function') { | |
| return await this.contract.manifest(); | |
| } else if (typeof this.contract.manifestUrl === 'function') { | |
| return await this.contract.manifestUrl(); | |
| } else { | |
| throw new Error('No known manifest prop'); | |
| } |
Is something like the above possible to simplify the code?
Collaborator
Author
There was a problem hiding this comment.
with the new ABI this if (typeof this.contract.manifestUrl === 'function') will never be true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Closes #3811
Context behind the change
Core contracts:
Escrow.setup(...)to remove fee arguments and fetch per-oracle fee fromKVStore.get(oracle, "fee").<= 25)<= 100)kvstoredependency to escrow deployment path:EscrowconstructorEscrowFactoryEscrowFactory.initialize(...)to accept_kvstoresetKVStoreAddress(...)admin method for upgrades.IEscrow.setup(...)without fee paramsEscrowFactory.createFundAndSetupEscrow(...)without fee params.TypeScript SDK:
EscrowClient.setup(...)andcreateFundAndSetupEscrow(...).Python SDK:
setupandcreate_fund_and_setup_escrow.EscrowConfigfor compatibility, but ignore them in calls.How has this been tested?
Release plan
Potential risks; What to monitor; Rollback plan