Skip to content

Workflow harden: fail fast on missing governed PR tooling path - #23

Merged
hummbl-dev merged 1 commit into
mainfrom
ci/codex/hardfail-governed-pr-check
Jul 9, 2026
Merged

Workflow harden: fail fast on missing governed PR tooling path#23
hummbl-dev merged 1 commit into
mainfrom
ci/codex/hardfail-governed-pr-check

Conversation

@hummbl-dev

Copy link
Copy Markdown
Collaborator

Summary

Adds a fast-fail guard in governed-pr-check reusable workflow before script execution.

Changes

  • Adds Validate governed PR check tooling source step before invoking governed_pr_check.py.
  • Checks governed-pr-check-tools/.github/scripts/governed_pr_check.py and fails fast with explicit wrong workflow revision/tooling source error messaging when absent.
  • Adds migration hints when only legacy path .github/scripts/governed_pr_check.py exists.
  • Emits explicit error when neither expected path exists.

Definition of done

  • Missing script-path runs fail quickly.
  • Failure message is actionable for changing reusable workflow revision/source.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8758ae42-a11c-4faf-8d82-98b5fe3a0146

📥 Commits

Reviewing files that changed from the base of the PR and between 9e9c64c and 7f48483.

📒 Files selected for processing (1)
  • .github/workflows/governed-pr-check.yml

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Added an early validation step to catch misconfigured governed PR checks before the main check runs.
    • When the expected tooling is missing, the workflow now reports clearer failure details and points to a likely outdated pinned revision.

Walkthrough

Adds a pre-flight validation step to the governed PR check GitHub Actions workflow. The step verifies the primary tooling script exists before running the main check, writing hard-fail details to the step summary and emitting error annotations if missing, including detection of a legacy script path.

Changes

Workflow validation step

Layer / File(s) Summary
Add pre-flight script existence validation
.github/workflows/governed-pr-check.yml
New step checks for the expected governed PR check script, writes hard-fail details to $GITHUB_STEP_SUMMARY, emits ::error:: annotations (differentiating legacy script paths), and exits with status 1 if missing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • hummbl-dev/hummbl-dev#123: Implements the same fail-fast governed PR check script-path validation and legacy-path hinting described in that issue.

Poem

A rabbit checks the path with care,
"Is the script really there?"
If not, I'll flag it loud and clear,
No legacy ghosts allowed round here! 🐇
Hop on, workflow, safe and sound.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and changes, but misses required template sections like Linked Issue, Boundary, Source Status, Change Class, Evidence, and Notes. Add the repository template sections: Linked Issue, Boundary, Source Status, Change Class, Evidence/tests and receipt, and Notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a fail-fast guard for the governed PR tooling path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/codex/hardfail-governed-pr-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hummbl-dev
hummbl-dev merged commit 7c74478 into main Jul 9, 2026
2 checks passed
@hummbl-dev
hummbl-dev deleted the ci/codex/hardfail-governed-pr-check branch July 9, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant