Feat/record and play framework#490
Open
WuonParticle wants to merge 45 commits intohummingbot:developmentfrom
Open
Feat/record and play framework#490WuonParticle wants to merge 45 commits intohummingbot:developmentfrom
WuonParticle wants to merge 45 commits intohummingbot:developmentfrom
Conversation
3cdeed9 to
3105bf2
Compare
672c179 to
6d8b2e3
Compare
cc96cde to
9bd329a
Compare
Contributor
Author
|
Separated the "Play" tests from the primary test suite today with 9bd329a as LLM agents were running the unit test suite with -u to force snapshots to avoid having to actually debug issues. Also clarified everywhere "Record" and "Play" Tests rather than saying unit. |
Contributor
Author
|
I recommend doing a squash merge when eventually merging this as 42 commits is pretty outrageous for the functionality being added. However, I think keeping the git history in the PR is important for posterity and to understand why some design decisions were made. |
… responses on same dependency.
…lly. 400 makes more sense for invalid input anyway.
clarify that setup file is run per suite rather than once globally.
…re okay to ignore during playback.
…chains. rename useDep2 to useUnmappedDep. Also made complimentary useUnmappedMethodMocked and useUnmappedMethodRecorder to produce clean test pass output.
…large number of parameters.
… clarify explicitly that the output varies between the two.
… names with gemini-2.5-pro.
…rd-and-play files under test/ . Prevent snapshot updates during "Play" tests.
9bd329a to
f114828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
New Features
Bug Fixes
Chores
Documentation
Tests performed by the developer:
pnpm test-record(changes files intentionally)pnpm test rnp
Tips for QA testing:
pnpm test- verify that all tests passpnpm test rnp- verify that only tests with rnp in the name are run and passpnpm test-play- verify that only play tests are run and passpnpm test-record- verify that rnpExample mock files and snapshot file changes changepnpm test-play- verify that only rnp tests are run and passpnpm test-play- verify that rnpExample play tests relying on mocks failpnpm test-play- verify that tests pass