Skip to content

fix: use full withdraw_direct handler and correct integration test funding#2

Open
mooncitydev wants to merge 1 commit intohydex-org:mainfrom
mooncitydev:fix/withdraw-direct-handler
Open

fix: use full withdraw_direct handler and correct integration test funding#2
mooncitydev wants to merge 1 commit intohydex-org:mainfrom
mooncitydev:fix/withdraw-direct-handler

Conversation

@mooncitydev
Copy link
Copy Markdown

summary

The program entrypoint for \withdraw_direct\ was a minimal inline implementation that:

  1. Rent safety — It compared raw lamports to \�mount\ and could move SOL out of the vault authority PDA until it dropped below rent-exempt minimum, which can brick the account (runtime eviction / failed future ops). The instruction module already had the correct logic: reserve \Rent::minimum_balance(VaultAuthority::LEN)\ before allowing SOL moves.

  2. Dead code / drift — \programs/hydentity/src/instructions/withdraw_direct.rs\ implemented the real behavior (SOL + optional SPL CPI) and matches what the app and IDL expect (token program + optional token accounts). The on-chain program was not calling it.

This PR wires \withdraw_direct\ to \withdraw_handler\ and removes the duplicate account struct.

tests

The integration test airdropped SOL to the NameVault PDA, but direct withdrawal debits the vault authority PDA. Funding was updated so the test actually exercises the withdrawal path.


I ran \�nchor build\ / \�nchor test\ locally where the toolchain is available; please run them in CI or locally to confirm.

Made with Cursor

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

@mooncitydev is attempting to deploy a commit to the Hydex Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant