fix: use full withdraw_direct handler and correct integration test funding#2
Open
mooncitydev wants to merge 1 commit intohydex-org:mainfrom
Open
fix: use full withdraw_direct handler and correct integration test funding#2mooncitydev wants to merge 1 commit intohydex-org:mainfrom
mooncitydev wants to merge 1 commit intohydex-org:mainfrom
Conversation
|
@mooncitydev is attempting to deploy a commit to the Hydex Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
The program entrypoint for \withdraw_direct\ was a minimal inline implementation that:
Rent safety — It compared raw lamports to \�mount\ and could move SOL out of the vault authority PDA until it dropped below rent-exempt minimum, which can brick the account (runtime eviction / failed future ops). The instruction module already had the correct logic: reserve \Rent::minimum_balance(VaultAuthority::LEN)\ before allowing SOL moves.
Dead code / drift — \programs/hydentity/src/instructions/withdraw_direct.rs\ implemented the real behavior (SOL + optional SPL CPI) and matches what the app and IDL expect (token program + optional token accounts). The on-chain program was not calling it.
This PR wires \withdraw_direct\ to \withdraw_handler\ and removes the duplicate account struct.
tests
The integration test airdropped SOL to the NameVault PDA, but direct withdrawal debits the vault authority PDA. Funding was updated so the test actually exercises the withdrawal path.
I ran \�nchor build\ / \�nchor test\ locally where the toolchain is available; please run them in CI or locally to confirm.
Made with Cursor