Replace SRF dataset check in gaseous_correction.py#1
Merged
fsteinmetz merged 1 commit intohygeos:mainfrom Feb 16, 2026
Merged
Conversation
Replace SRF check in Gas_correction_O3 class init function in gaseous_correction.py. In Polymer, the SRF dataset is initialized as an empty xr.Dataset if sensor SRFs are not provided. The current check `if srf is not None:` reaches the assert statement even if there is an empty SRF dataset and results in an Exception. This commit updates the check to be the same as the one in Gas_correction_O3() on line 222.
Contributor
|
Thanks ! I have merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace SRF check in Gas_correction_O3 class init function in gaseous_correction.py. In Polymer, the SRF dataset is initialized as an empty xr.Dataset if sensor SRFs are not provided. The current check
if srf is not None:reaches the assert statement even if there is an empty SRF dataset and results in an Exception. This commit updates the check to be the same as the one in Gas_correction_O3() on line 222.