Skip to content

Comments

chore(proto): regenerate worker v1 Go protobuf/grpc stubs#66

Open
hyp3rd wants to merge 1 commit intomainfrom
feat/admin-ui
Open

chore(proto): regenerate worker v1 Go protobuf/grpc stubs#66
hyp3rd wants to merge 1 commit intomainfrom
feat/admin-ui

Conversation

@hyp3rd
Copy link
Owner

@hyp3rd hyp3rd commented Feb 21, 2026

Updates generated *.pb.go / *_grpc.pb.go for admin/payload/worker:

  • align imports (protoreflect/protoimpl) and ordering
  • minor formatting/whitespace cleanups in grpc server stubs No intended functional changes.

Updates generated *.pb.go / *_grpc.pb.go for admin/payload/worker:
- align imports (protoreflect/protoimpl) and ordering
- minor formatting/whitespace cleanups in grpc server stubs
No intended functional changes.
Copilot AI review requested due to automatic review settings February 21, 2026 20:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the Go protobuf and gRPC stubs for worker/v1 to reflect updated generator output and formatting, with no intended behavioral changes.

Changes:

  • Regenerated *.pb.go files with updated import ordering and minor code layout changes.
  • Regenerated *_grpc.pb.go server/client stubs with whitespace/formatting adjustments (notably import grouping and spacing between methods).
  • Minor reshaping of generated var declarations (e.g., splitting var (...) blocks into separate var statements).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pkg/worker/v1/worker_grpc.pb.go Regenerated WorkerService gRPC stubs; whitespace/import formatting updates.
pkg/worker/v1/worker.pb.go Regenerated worker proto types; import ordering and generated var layout changes.
pkg/worker/v1/payload.pb.go Regenerated payload proto types; import ordering and generated var layout changes.
pkg/worker/v1/admin_grpc.pb.go Regenerated AdminService gRPC stubs; whitespace/import formatting updates.
pkg/worker/v1/admin.pb.go Regenerated admin proto types; import ordering and generated var layout changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -8,7 +8,6 @@ package workerpb

import (
context "context"
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generated gRPC stub removed the blank line separating stdlib and third-party imports. gofmt/gofumpt will re-introduce the import grouping; since this repo runs gofumpt in make lint, please run gofumpt/gofmt after regeneration to keep the generated output stable.

Suggested change
context "context"
context "context"

Copilot uses AI. Check for mistakes.
@@ -8,7 +8,6 @@ package workerpb

import (
context "context"
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generated gRPC stub removed the blank line separating stdlib and third-party imports. gofmt/gofumpt will reformat this; since make lint runs gofumpt over GOFILES, please run gofumpt/gofmt after regeneration so the committed generated output matches formatting expectations.

Suggested change
context "context"
context "context"

Copilot uses AI. Check for mistakes.
Comment on lines 10 to +16
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
anypb "google.golang.org/protobuf/types/known/anypb"
durationpb "google.golang.org/protobuf/types/known/durationpb"
reflect "reflect"
sync "sync"
unsafe "unsafe"
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import block is no longer gofmt/gofumpt-compliant (stdlib imports like reflect are placed after third-party protobuf imports and there’s no stdlib/third-party grouping). Since this repo runs gofumpt over GOFILES in make lint, this will be rewritten and can cause recurring diffs. Please regenerate and/or run gofumpt (or gofmt) on the generated stubs so imports are grouped and ordered consistently.

Suggested change
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
anypb "google.golang.org/protobuf/types/known/anypb"
durationpb "google.golang.org/protobuf/types/known/durationpb"
reflect "reflect"
sync "sync"
unsafe "unsafe"
reflect "reflect"
sync "sync"
unsafe "unsafe"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
anypb "google.golang.org/protobuf/types/known/anypb"
durationpb "google.golang.org/protobuf/types/known/durationpb"

Copilot uses AI. Check for mistakes.
Comment on lines +10 to 14
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
unsafe "unsafe"
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import block is not gofmt/gofumpt-compliant (protobuf imports are mixed with stdlib imports without grouping). Given make lint runs gofumpt across GOFILES, this will be rewritten. Please run gofumpt/gofmt after regenerating so the import grouping is stable.

Suggested change
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
unsafe "unsafe"
"reflect"
"sync"
"unsafe"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"

Copilot uses AI. Check for mistakes.
Comment on lines +10 to 14
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
unsafe "unsafe"
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import block is not gofmt/gofumpt-compliant (protobuf imports are placed before stdlib imports with no blank line grouping). Since make lint runs gofumpt, this will be rewritten and may cause repeated churn. Please run gofumpt/gofmt on the regenerated file so imports are grouped consistently.

Suggested change
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
unsafe "unsafe"
reflect "reflect"
sync "sync"
unsafe "unsafe"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant