Reject non-finite polling timing configuration

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -1,4 +1,5 @@
 import asyncio
+import math
 from numbers import Real
 import time
 from typing import Awaitable, Callable, Optional, TypeVar
@@ -12,6 +13,15 @@
 T = TypeVar("T")
 
 
+def _validate_non_negative_real(value: float, *, field_name: str) -> None:
+    if isinstance(value, bool) or not isinstance(value, Real):
+        raise HyperbrowserError(f"{field_name} must be a number")
+    if not math.isfinite(float(value)):
+        raise HyperbrowserError(f"{field_name} must be finite")
+    if value < 0:
+        raise HyperbrowserError(f"{field_name} must be non-negative")
+
+
 def _validate_operation_name(operation_name: str) -> None:
     if not isinstance(operation_name, str):
         raise HyperbrowserError("operation_name must be a string")
@@ -29,12 +39,7 @@ def _validate_retry_config(
         raise HyperbrowserError("max_attempts must be an integer")
     if max_attempts < 1:
         raise HyperbrowserError("max_attempts must be at least 1")
-    if isinstance(retry_delay_seconds, bool) or not isinstance(
-        retry_delay_seconds, Real
-    ):
-        raise HyperbrowserError("retry_delay_seconds must be a number")
-    if retry_delay_seconds < 0:
-        raise HyperbrowserError("retry_delay_seconds must be non-negative")
+    _validate_non_negative_real(retry_delay_seconds, field_name="retry_delay_seconds")
     if max_status_failures is not None:
         if isinstance(max_status_failures, bool) or not isinstance(
             max_status_failures, int
@@ -45,21 +50,15 @@ def _validate_retry_config(
 
 
 def _validate_poll_interval(poll_interval_seconds: float) -> None:
-    if isinstance(poll_interval_seconds, bool) or not isinstance(
-        poll_interval_seconds, Real
-    ):
-        raise HyperbrowserError("poll_interval_seconds must be a number")
-    if poll_interval_seconds < 0:
-        raise HyperbrowserError("poll_interval_seconds must be non-negative")
+    _validate_non_negative_real(
+        poll_interval_seconds, field_name="poll_interval_seconds"
+    )
 
 
 def _validate_max_wait_seconds(max_wait_seconds: Optional[float]) -> None:
-    if max_wait_seconds is not None and (
-        isinstance(max_wait_seconds, bool) or not isinstance(max_wait_seconds, Real)
-    ):
-        raise HyperbrowserError("max_wait_seconds must be a number")
-    if max_wait_seconds is not None and max_wait_seconds < 0:
-        raise HyperbrowserError("max_wait_seconds must be non-negative")
+    if max_wait_seconds is None:
+        return
+    _validate_non_negative_real(max_wait_seconds, field_name="max_wait_seconds")
 
 
 def _validate_page_batch_values(

tests/test_polling.py

@@ -1,4 +1,5 @@
 import asyncio
+import math
 
 import pytest
 
@@ -755,6 +756,35 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             retry_delay_seconds=0.0,
         )
 
+    with pytest.raises(HyperbrowserError, match="retry_delay_seconds must be finite"):
+        retry_operation(
+            operation_name="invalid-retry-delay-finite",
+            operation=lambda: "ok",
+            max_attempts=1,
+            retry_delay_seconds=math.inf,
+        )
+
+    with pytest.raises(HyperbrowserError, match="poll_interval_seconds must be finite"):
+        poll_until_terminal_status(
+            operation_name="invalid-poll-interval-finite",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=math.nan,
+            max_wait_seconds=1.0,
+        )
+
+    with pytest.raises(HyperbrowserError, match="max_wait_seconds must be finite"):
+        collect_paginated_results(
+            operation_name="invalid-max-wait-finite",
+            get_next_page=lambda page: {"current": 1, "total": 1, "items": []},
+            get_current_page_batch=lambda response: response["current"],
+            get_total_page_batches=lambda response: response["total"],
+            on_page_success=lambda response: None,
+            max_wait_seconds=math.inf,
+            max_attempts=1,
+            retry_delay_seconds=0.0,
+        )
+
     async def validate_async_operation_name() -> None:
         with pytest.raises(HyperbrowserError, match="operation_name must not be empty"):
             await poll_until_terminal_status_async(