Wrap session upload file-open errors with HyperbrowserError

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -2,6 +2,7 @@
 from os import PathLike
 from typing import IO, List, Optional, Union, overload
 import warnings
+from hyperbrowser.exceptions import HyperbrowserError
 from ....models.session import (
     BasicResponse,
     CreateSessionParams,
@@ -113,12 +114,19 @@ async def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
-            with open(os.fspath(file_input), "rb") as file_obj:
-                files = {"file": file_obj}
-                response = await self._client.transport.post(
-                    self._client._build_url(f"/session/{id}/uploads"),
-                    files=files,
-                )
+            file_path = os.fspath(file_input)
+            try:
+                with open(file_path, "rb") as file_obj:
+                    files = {"file": file_obj}
+                    response = await self._client.transport.post(
+                        self._client._build_url(f"/session/{id}/uploads"),
+                        files=files,
+                    )
+            except OSError as exc:
+                raise HyperbrowserError(
+                    f"Failed to open upload file at path: {file_path}",
+                    original_error=exc,
+                ) from exc
         elif callable(getattr(file_input, "read", None)):
             files = {"file": file_input}
             response = await self._client.transport.post(

hyperbrowser/client/managers/sync_manager/session.py

@@ -2,6 +2,7 @@
 from os import PathLike
 from typing import IO, List, Optional, Union, overload
 import warnings
+from hyperbrowser.exceptions import HyperbrowserError
 from ....models.session import (
     BasicResponse,
     CreateSessionParams,
@@ -105,12 +106,19 @@ def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
-            with open(os.fspath(file_input), "rb") as file_obj:
-                files = {"file": file_obj}
-                response = self._client.transport.post(
-                    self._client._build_url(f"/session/{id}/uploads"),
-                    files=files,
-                )
+            file_path = os.fspath(file_input)
+            try:
+                with open(file_path, "rb") as file_obj:
+                    files = {"file": file_obj}
+                    response = self._client.transport.post(
+                        self._client._build_url(f"/session/{id}/uploads"),
+                        files=files,
+                    )
+            except OSError as exc:
+                raise HyperbrowserError(
+                    f"Failed to open upload file at path: {file_path}",
+                    original_error=exc,
+                ) from exc
         elif callable(getattr(file_input, "read", None)):
             files = {"file": file_input}
             response = self._client.transport.post(

tests/test_session_upload_file.py

@@ -9,6 +9,7 @@
 from hyperbrowser.client.managers.sync_manager.session import (
     SessionManager as SyncSessionManager,
 )
+from hyperbrowser.exceptions import HyperbrowserError
 
 
 class _FakeResponse:
@@ -156,3 +157,22 @@ async def run():
             await manager.upload_file("session_123", fake_file)
 
     asyncio.run(run())
+
+
+def test_sync_session_upload_file_raises_hyperbrowser_error_for_missing_path(tmp_path):
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+    missing_path = tmp_path / "missing-file.txt"
+
+    with pytest.raises(HyperbrowserError, match="Failed to open upload file"):
+        manager.upload_file("session_123", missing_path)
+
+
+def test_async_session_upload_file_raises_hyperbrowser_error_for_missing_path(tmp_path):
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+    missing_path = tmp_path / "missing-file.txt"
+
+    async def run():
+        with pytest.raises(HyperbrowserError, match="Failed to open upload file"):
+            await manager.upload_file("session_123", missing_path)
+
+    asyncio.run(run())