chore(deps-dev): bump nx from 21.3.11 to 22.7.2 - #2762
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
PR author is in the excluded authors list. |
🟢 Tier 1 — TrivialDocs, images, lock files, or a dependency bump. No functional code changes detected. Why this tier:
Review process: Auto-merge once CI passes. No human review required. Stats
|
E2E Test Results❌ Error reading test results: ENOENT: no such file or directory, scandir 'all-test-results' |
|
<!-- deep-review --> Deep Review✅ No critical issues found. This is a manifest + lockfile change only ( The substance of this review is that a major version jump (21 → 22) landed with zero migration artifacts, against an 🟡 P2 -- recommended
🔵 P3 nitpicks (6)
Reviewers (7): correctness, testing, maintainability, project-standards, reliability, learnings-researcher, validator Testing gaps:
Review limitations: |
|
@dependabot recreate |
Bumps [nx](https://github.com/nrwl/nx/tree/HEAD/packages/nx) from 21.3.11 to 22.7.2. - [Release notes](https://github.com/nrwl/nx/releases) - [Commits](https://github.com/nrwl/nx/commits/22.7.2/packages/nx) --- updated-dependencies: - dependency-name: nx dependency-version: 22.7.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
25818a2 to
2fe12b1
Compare
Deep Review✅ No critical issues found. This is a dev-dependency-only change: root 🟡 P2 -- recommended
🔵 P3 nitpicks (1)
Reviewers (6): project-standards (returned, zero findings), correctness, testing, maintainability, security, learnings-researcher (dispatched; had not returned when this report was assembled — their findings are not represented here). Coverage caveats:
Testing gaps:
|
|
@claude please evaluate the linting failure on this branch and suggest a path forward |
|
Claude finished @teeohhem's task in 6m 0s —— View job Lint failure: root cause found
The Same error takes down Root causeThe root // package.json:79
"brace-expansion": "^2.1.2",That collapses the whole graph to a single lockfile entry ( // node_modules/brace-expansion/index.js:3
module.exports = expandTop; // no named `.expand`The 21 → 22 bump changes which API shape nx needs:
nx 22 also pins This is a latent bug on
Today nothing in CI feeds them a On the security intent of the clampWorth knowing before loosening it: the pinned 2.1.2 carries the exponential-blowup / ReDoS fixes (CVE-2025-5889 class, fixed in 1.1.12 / 2.0.2 / 3.0.1 / 4.0.1 — so 5.0.5 has them too). It does not carry the fix for the newer OOM advisory it ships as documentation ( So letting the 5.x line resolve to 5.0.5 regresses nothing: 5.0.5 is patched for the same CVE the clamp was added for, and both versions are equally exposed to the OOM one. The blanket clamp buys no extra protection over per-line pins — it only breaks the 5.x API contract. Path forwardOption A (recommended) — replace the blanket clamp with per-line pins. Yarn resolution patterns can carry a range, so each major line keeps its own API shape: - "brace-expansion": "^2.1.2",
+ "brace-expansion@^1.1.7": "^1.1.12",
+ "brace-expansion@^2.0.1": "^2.1.2",The five descriptors in the tree are Option B — keep the catch-all, add scoped overrides ahead of it. Yarn's + "brace-expansion@^5.0.2": "^5.0.5",
+ "brace-expansion@^5.0.5": "^5.0.5",
+ "brace-expansion@5.0.5": "5.0.5",
"brace-expansion": "^2.1.2",Works, but depends on ordering semantics that aren't obvious to the next reader, and leaves the latent minimatch-10 bug in place for any future 5.x descriptor. I'd prefer A. Option C — hold the bump. Legitimate if you'd rather not touch Suggested sequencing: land Option A as its own small PR against Verify with: yarn install --mode=update-lockfile # confirm 5.x descriptors are no longer rewritten to 2.1.2
npx nx show projects # cheapest reproduction of the crash
make ci-build && make ci-lint && make ci-unit
yarn npm audit --all --recursive # confirm no line lands on a pre-CVE-2025-5889 versionIf you want me to implement Option A, say the word and I'll open it against What I could not verify here
I also have not checked whether nx 22 surfaces further problems past startup ( --- • branch |
Bumps nx from 21.3.11 to 22.7.2.
Release notes
Sourced from nx's releases.
... (truncated)
Commits
4e9ea1bchore(core): refresh stale TUI snapshots on 22.7.xd02dc54fix(repo): unblock 22.7.x cargo tests and nx-build e2e7e4bce9feat(testing): add migration for Jest 30 snapshot guide link (#35629)43c0c82fix(core): cast perf entries to PerformanceMeasure for detail access0cfc6bcfix(core): allownx mcpto run outside of an Nx workspace (#35655)df0e414chore(core): remove dead TUI selection lifecycle helpers (#35649)a0f7a52fix(core): keep TUI task selection on the in-progress section (#35640)93813e9fix(core): support skipped batch tasks end-to-end and fix TUI double logs (#3...c514039fix(core): enable node's native v8 compile cache support (#35415)75e3498fix(core): isolate cache env vars in splitArgs spec (#35584)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for nx since your current version.
Install script changes
This version modifies
postinstallscript that runs during installation. Review the package contents before updating.