fix(types): Serialize BadRequest::FieldViolation reason and localized_message
#2461
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauravzg
reviewed
Dec 8, 2025
| } | ||
|
|
||
| #[test] | ||
| fn gen_bad_request_with_verbose_field_violation() { |
Collaborator
There was a problem hiding this comment.
I'd recommend either merging the business logic into the original test or creating an incremental fine grained test that tests just the new business logic that has been added in this change.
Author
There was a problem hiding this comment.
Thanks @sauravzg for the review! I've merged the new coverage into the original test as suggested. Let me know if this looks good to you.
sauravzg
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #2460
Fields
reasonandlocalized_messagefromBadRequest::FieldViolationare not serialized into the underlying protobuf message and therefore never make it onto the wire.Solution
Fix the conversion from
FieldViolationto the prost-generatedpb::bad_request::FieldViolationby explicitly forwarding both thereasonandlocalized_messagefields instead of leaving them at their default values.A new test is added to ensure that behavior.