Integrate supplementary Protocol Buffers (protobuf) parameters into the JS client to augment the extensibility and functionality of the data model within the designated oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information.#181
Closed
dominious1 wants to merge 5 commits intohyperledger-iroha:mainfrom
Closed
Integrate supplementary Protocol Buffers (protobuf) parameters into the JS client to augment the extensibility and functionality of the data model within the designated oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information.#181dominious1 wants to merge 5 commits intohyperledger-iroha:mainfrom
dominious1 wants to merge 5 commits intohyperledger-iroha:mainfrom
Conversation
This reverts commit 760acfb.
Signed-off-by: dominious1 <piotr567@proton.me>
baziorek
approved these changes
Dec 1, 2023
baziorek
left a comment
baziorek
left a comment
There was a problem hiding this comment.
LGTM, but I'm not Javascript specialist
…ge communication, with corresponding handling capabilities in Iroha CLI. Signed-off-by: dominious1 <140593941+dominious1@users.noreply.github.com>
|
@dominious1 Because I copied Your changes to another PR: #185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate additional Protocol Buffers (protobuf) parameters into the JS client, enhancing the extensibility and functionality of the data model within the specified 'oneof' constructs. This integration ensures a more comprehensive representation and utilization of transaction-related information, thereby expanding the capabilities and flexibility of the system.
Those changes are connected with: hyperledger-iroha/iroha#4003 - this is part of internship project:
https://wiki.hyperledger.org/pages/viewpage.action?pageId=80778614