fix: support peerDevMode with TLS enabled#731
Conversation
Signed-off-by: Abhishek <abhishekup082@gmail.com>
a031f20 to
8498cb5
Compare
|
Hi @dzikowski, This fixes #573 the validation was blocking peerDevMode and TLS from being used together, even though Fabric actually supports it. The fix is pretty minimal just removed the validation error and added the two required chaincode TLS env vars to the peer container in the docker-compose template. All existing tests still pass. Let me know if you'd like any changes. |
|
Please run locally a test with peer dev mode enabled, and TLS enabled. I believe it wont work, because the fundamental issue seems not resolved. See #573 |
|
it seems tests are failing, because snapshots are not updated. Take a look at: https://github.com/hyperledger-labs/fablo/blob/main/CONTRIBUTING.md |
|
Ok, I’ll check it. |
Fixes #573
Previously, using
peerDevMode: trueandtls: truetogether in the config would throw a validation error and block network generation. But this combination is actually valid Hyperledger Fabric supports it as long as the peer has the right chaincode TLS environment variables set.What changed:
peerDevMode + tlscombinationCORE_CHAINCODE_TLS_CERT_FILEandCORE_CHAINCODE_TLS_KEY_FILEenv vars to the peer container in the docker-compose template (only injected when bothpeerDevModeandtlsare enabled)Testing: