remove id caches #1283
Open
remove id caches #1283
+5
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
HayimShaul
force-pushed
the
1227-removing-one-show-ids-from-cache
branch
from
6f52e48 to
5989c62
Compare
added 12 commits
December 2, 2025 11:45
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
adecaro
reviewed
Dec 8, 2025
| func (p *Provider) RegisterVerifier(ctx context.Context, identity driver.Identity, v driver.Verifier) error { | ||
| if v == nil { | ||
| return errors.New("invalid verifier, expected a valid instance") | ||
| } |
Contributor
There was a problem hiding this comment.
it looks like this function is not really needed anymore. I would start an investigation on the callers of this function. Maybe we can save further cycles.
adecaro
reviewed
Dec 8, 2025
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed deserializing identity for signer [%s]", identity) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think we said to cache only the identity whose type is x509, no?
If we still cache the signers and the cache is only of size 5 there will be even more contention, no?
adecaro
reviewed
Dec 8, 2025
| if setAlias { | ||
| p.signers.Add(aliasID, entry) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
we are still caching any signer no matter the identity type. This will generate even more contention on the signers cache given its new size (5)
adecaro
requested changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove id caches