test(app): improve context cancellation handling in submission flow#223
Open
sachin9058 wants to merge 1 commit into
Open
test(app): improve context cancellation handling in submission flow#223sachin9058 wants to merge 1 commit into
sachin9058 wants to merge 1 commit into
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
Contributor
Author
|
Hi @mbrandenburger, I’ve opened this PR as a small follow-up improvement focused on context cancellation handling. It’s intentionally minimal and test-focused, without changing existing behavior. Whenever you have time, I’d really appreciate your feedback. Happy to make any adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves consistency of context cancellation handling across transaction submission flows.
Changes include:
Added early context checks at the start of
SubmitTransactionandSubmitTransactionWithWaitEnsured retry loop exits promptly when context is canceled
Added test coverage for:
These changes improve correctness and predictability without modifying existing behavior or APIs.
Additional details (Optional)
go test ./...)make lint)Related issues
Closes #192