fix(fxconfig/transaction): surface policy key parse errors#248
Open
Prachi194agrawal wants to merge 1 commit into
Open
fix(fxconfig/transaction): surface policy key parse errors#248Prachi194agrawal wants to merge 1 commit into
Prachi194agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Prachi Agrawal <prachi194agrawal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This change improves the error reporting when parsing threshold policy key material for
fxconfigcommands.Previously,
parseCertificateOrPublicKeyhad two silent failure paths:x509.ParsePKIXPublicKeyto be dropped, again returning only the generic message.In addition,
getPubKeyFromPemDatawould discard these detailed errors while iterating over PEM blocks and eventually return a single genericno ECDSA public key in pem filemessage to the caller.This PR:
parseCertificateOrPublicKeyto:certificate uses RSA algorithm, expected ECDSA.x509.ParsePKIXPublicKeyasfailed to parse public key: <underlying error>.getPubKeyFromPemDatato:no ECDSA public key in pem file: <underlying error>when no usable key is found.With these changes, users of:
fxconfig namespace create --threshold-policy <path>fxconfig namespace update --threshold-policy <path>now see clear, actionable error messages that distinguish between algorithm mismatch, corrupt key material, and the absence of any ECDSA key in the file.
Additional details (Optional)
The tests are written to be resilient to small differences in Go’s ASN.1 error strings by checking for either the wrapped message prefix (
failed to parse public key) or the presence of"asn1"in the error text.Related issues