Skip to content

Closes #1076: Code refactor to set trace context in run_vcpu function.#1181

Closed
vshailesh wants to merge 1 commit into
hyperlight-dev:mainfrom
vshailesh:telemetry-refactor
Closed

Closes #1076: Code refactor to set trace context in run_vcpu function.#1181
vshailesh wants to merge 1 commit into
hyperlight-dev:mainfrom
vshailesh:telemetry-refactor

Conversation

@vshailesh

Copy link
Copy Markdown
Contributor
  • Small change to set up the guest trace context function call inside the run_vcpu function instead, to prevent any human error in future code changes.

@ludfjig

ludfjig commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Thanks a lot for this! Looks like CI wants you to run a just fmt-apply, and a variable seems to be unused unless tracing feature is turned on. I would probably just name this parameter _tc so clippy doesn't complain about it if it's unused.

…_vcpu function.

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>
@vshailesh

Copy link
Copy Markdown
Contributor Author

pushed again, completely forgot about clippy checks.

@vshailesh

Copy link
Copy Markdown
Contributor Author

retracting this PR.

@vshailesh vshailesh closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants