Fix publish workflow to account for recent changes#1588
Merged
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several GitHub Actions workflows to explicitly pass a CPU architecture to the reusable dep_build_guests.yml workflow. This aligns the “publish-adjacent” workflows with the recent introduction of multi-architecture support, where dep_build_guests.yml now requires an arch input.
Changes:
- Pass
arch: X64todep_build_guests.ymlfrom Prime Caches, Fuzzing, Daily Benchmarks, and Create Release workflows. - Ensures these workflows satisfy the reusable workflow’s required
archinput and can run successfully.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/PrimeCaches.yml | Adds arch: X64 when calling dep_build_guests.yml to keep cache priming working with required arch input. |
| .github/workflows/Fuzzing.yml | Adds arch: X64 to the guest build step so scheduled/manual fuzzing can build release guest artifacts. |
| .github/workflows/DailyBenchmarks.yml | Adds arch: X64 to the guest build job required by the benchmark suite. |
| .github/workflows/CreateRelease.yml | Adds arch: X64 to the guest build job used by release/benchmark/publish flow. |
dblnz
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent changes to support aarch64, we now need to specify the arch in a few places.
This was missing for the publish workflows.