Adds optional repo variables for job timeout values#1600
Merged
simongdavies merged 2 commits intoJun 29, 2026
Merged
Conversation
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
andreiltd,
dblnz,
devigned,
jprendes,
jsturtevant,
ludfjig,
squillace and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several GitHub Actions workflows to allow job-level timeout-minutes values to be overridden via repository variables, reducing the need for PRs when timeouts need temporary adjustment.
Changes:
- Replaced hardcoded
timeout-minutesvalues with expressions that read optional repo variables and fall back to the existing defaults. - Applied this pattern across nightly, coverage, cache-priming, and dependency-related workflows.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/RustNightly.yml | Makes the nightly musl job timeout configurable via a repo variable (with fallback). |
| .github/workflows/PrimeCaches.yml | Makes the prime-caches job timeout configurable via a repo variable (with fallback). |
| .github/workflows/dep_update_guest_locks.yml | Makes the update-guest-locks job timeout configurable via a repo variable (with fallback). |
| .github/workflows/dep_run_examples.yml | Makes the run-examples job timeout configurable via a repo variable (with fallback). |
| .github/workflows/dep_code_checks.yml | Makes linux/windows code-check jobs’ timeouts configurable via a repo variable (with fallback). |
| .github/workflows/dep_build_test.yml | Makes the build-and-test job timeout configurable via a repo variable (with fallback). |
| .github/workflows/dep_build_guests.yml | Makes the build-guests job timeout configurable via a repo variable (with fallback). |
| .github/workflows/dep_benchmarks.yml | Makes the benchmarks job timeout configurable via a repo variable (with fallback). |
| .github/workflows/Coverage.yml | Makes the coverage job timeout configurable via a repo variable (with fallback). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
jprendes
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeout values on GH jobs are hardcoded, this means that if we need to change any of these values even temporarily then we need to submit a PR, this PR allows the timeout value for each job to be optionally read from a repo variable. The hardcoded (fallback) values are not changed.