Skip to content

Conversation

@fsb4000
Copy link

@fsb4000 fsb4000 commented Dec 18, 2018

No description provided.

@fsb4000 fsb4000 changed the title Stage #3: Gauss-Jordan Elimination Stage #4: Handle special cases Dec 20, 2018
@fsb4000 fsb4000 changed the title Stage #4: Handle special cases Stage #5: Support for complex numbers Dec 28, 2018
Copy link

@aaaaaa2493 aaaaaa2493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. You did a massive job here!

I use your solution for writing unit tests for all of the stages of this project, so thank you!

But I found a bug somewhere in Java implementation.

For the input

3 4
1 1 2 9
0 1 3 1
0 2 6 1
0 0 0 0

Your program outputs

An exception occurs Index 3 out of bounds for length 3

But should

No solutions

@fsb4000
Copy link
Author

fsb4000 commented Jan 24, 2019

@aaaaaa2493 . Thank you very much! I fixed the bug.

Copy link

@aaaaaa2493 aaaaaa2493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Also, I noticed that you support only 1i but not i although they are the same thing basically.
In complex examples like 2-1i a 1 before i also can be omitted like in 2-i.

I didn't pay attention to this while writing the project stage description, but now I added this information.

@fsb4000
Copy link
Author

fsb4000 commented Jan 25, 2019

@aaaaaa2493 Thanks, I will implement it today or maybe tomorrow. Also I found a bug at hyperskill.org: After I finished the project, I can't reread the project stage descriptions (for such situations like that)
Screenshot:
hyperskill

@aaaaaa2493
Copy link

Did you choose another project? For now, you are unable to see project description if you don't choose this project.

@fsb4000
Copy link
Author

fsb4000 commented Jan 26, 2019

@aaaaaa2493 , Yes, I chose another project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants