Reimplement Project Template #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Valkryst wants to merge 2 commits into hyperskill:master from Valkryst:fix-issues

Valkryst commented Nov 2, 2023

This PR fixes some minor annoyances that I ran into when starting the project on Hyperskill:

Updated ApplicationRunner to start the Swing application on the EDT.
Updated the constructor in WebCrawler to:
- Add a title to the frame.
- Remove setLayout(null) as it seemed to serve no purpose.
- Swap setSize for setPreferredSize.
- Update all superclass calls to explicitly use super. for clarity.
- Update the order of operations to ensure the frame is centered on the screen when started.

Valkryst added 2 commits

November 2, 2023 11:42


          Fix issue where the application was not started on the EDT


          Rewrite WebCrawler's constructor

f0c398f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet