Do not compress recently added MIME types in Metadata#1126
Merged
ArneBab merged 1 commit intohyphanet:nextfrom Feb 15, 2026
Merged
Do not compress recently added MIME types in Metadata#1126ArneBab merged 1 commit intohyphanet:nextfrom
ArneBab merged 1 commit intohyphanet:nextfrom
Conversation
Registering MIME types causes their values to be short-encoded in the Manifest of an insert. This causes a breaking change for these file types: their keys change, depending on whether the file was inserted before or after the newly introduced MIME type. This is not desired, CHK keys should be stable. Prevent newly registered MIME types from getting encoded as short value (compressed) in the manifest to ensure insert key stability.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering MIME types causes their values to be short-encoded in the Manifest of an insert. This causes a breaking change for these file types: their keys change, depending on whether the file was inserted before or after the newly introduced MIME type. This is not desired, CHK keys should be stable.
Prevent newly registered MIME types from getting encoded as short value (compressed) in the manifest to ensure insert key stability.