Remove helm client-init #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchugalinskiy
force-pushed
the
remove-client-init
branch
from
7f5d7cf to
1a63737
Compare
kchugalinskiy
force-pushed
the
remove-client-init
branch
from
1a63737 to
9bf1ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit helm --client-init is not evil by itself, but it causes frozen helm chart versions and potentially may lead to surprising bugs, as
helm upcommand is almost obligatory although not specified in any docs.As for me, helm command should fail by default, this is lesser evil in this case.