feat: add config option to disable the non-printable utf8 escaping#685
Open
cslecours wants to merge 1 commit intoi18next:masterfrom
Open
feat: add config option to disable the non-printable utf8 escaping#685cslecours wants to merge 1 commit intoi18next:masterfrom
cslecours wants to merge 1 commit intoi18next:masterfrom
Conversation
Author
|
This is only a proof of concept : if the idea is approved, I can get the PR in a state where it's ready to merge, but I would not waste too much time if it's not the case :) In my repo I have removed this part using |
Member
|
Thanks for the PR. If you add a test for the new behaviour, I'll be happy to merge it. |
|
Is there any update on this being merged? We're having issues with this affecting every commit we try to do in our codebase |
Member
|
@brianmotherway The change is not tested. If you want to take over the PR and write a test for it, I'll review and merge it |
Author
|
@brianmotherway, if you write the tests that would be super helpful! 🙏 |
d72e758 to
10f3d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
In my project, when I run i18next-parser, I get the converted entities, however, my automated translation tool converts them back to the non-escaped sequence.
This has become a little dance where as soon as I merge the translations I get another PR from the service to change it back.
Does it fix an existing ticket?
Yes/No #000
Checklist
yarn test(see details here)