Adding .gitattributes file and normalizing CRFL lines for git#5
Open
allyunion wants to merge 2 commits intoi2b2:masterfrom
Open
Adding .gitattributes file and normalizing CRFL lines for git#5allyunion wants to merge 2 commits intoi2b2:masterfrom
allyunion wants to merge 2 commits intoi2b2:masterfrom
Conversation
Contributor
|
I'm reviewing this, it changes line endings in 55 files a might break our repo, so I'm not inclined to merge it. Were the line endings causing problems in your installation? |
Author
|
Yes.
…On Thu, Sep 19, 2019 at 2:23 PM Jeff Klann ***@***.***> wrote:
I'm reviewing this, it changes line endings in 55 files a might break our
repo, so I'm not inclined to merge it. Were the line endings causing
problems in your installation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/i2b2/i2b2-webclient/pull/5?email_source=notifications&email_token=AALHBM3HQTTAIGHW7RFAOATQKPUVDA5CNFSM4DXDCCAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7E3YEQ#issuecomment-533314578>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALHBM4OK5EA43OOTE4DAVDQKPUVDANCNFSM4DXDCCAA>
.
|
Contributor
|
Can you elaborate? |
Author
|
Yes. Because the servers I run are Linux based, the extra \r lines get
processed, resulting the page to have errors.
…On Mon, Sep 23, 2019, 1:23 PM Jeff Klann ***@***.***> wrote:
Can you elaborate?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/i2b2/i2b2-webclient/pull/5?email_source=notifications&email_token=AALHBM7OQIQXVCARN5M2M3TQLEQVPA5CNFSM4DXDCCAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MEXXQ#issuecomment-534268894>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALHBM4OSWOLJCIMFTE7BADQLEQVPANCNFSM4DXDCCAA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the guidelines set by GitHub here:
https://help.github.com/articles/dealing-with-line-endings/