Fix log line leading space handled differently by Kodi Piers#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Preserve leading whitespace in log output (e.g. stack traces)
Problem
Leading spaces at the beginning of log lines (e.g. indented stack traces) are silently stripped when displayed in the Kodi textbox control, breaking the formatting of indented log content.
Root cause
The bug was introduced in Kodi 22 Piers (merged via xbmc/xbmc#27403) as an unintended side effect of a
WrapText()performance optimization in GUITextLayout.cpp.The new implementation introduced a
skipLeadingSpaceslambda that is called after every line break during word-wrapping. While intended to avoid leading spaces after automatic line breaks, it inadvertently also strips intentional indentation at the start of lines that follow a wrapped line.CGUITextBoxis always initialized withwrap=true, so this code path is always active. The bug does not affect Kodi 21 Omega or earlier.@sundermann fyi