dctsxycdxcx #3
Open
dctsxycdxcx #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunshcn
reviewed
Jan 21, 2021
Contributor
hunshcn
left a comment
hunshcn
left a comment
There was a problem hiding this comment.
没啥好说的，写的还可以。有这么些地方可以改进：
- 按钮可以加入视觉反馈，感觉按了跟没按一样。
- 用js来执行计算是做计算器不错的选择，嗯不过相比自己手撸计算流程缺了些锻炼。
- 逻辑上，我执行完了之后再点击数字应该是直接覆盖而不是数字跟在后面。
| }) | ||
| } | ||
| if(index == 19){ | ||
| var result = rpn.calCommonExp(screenData); |
| <block wx:for="{{ztNum}}" wx:key="zt"> | ||
| <view class='ztit {{(index < 4 || index % 4 == 3 ) ? "gray" : "white"}}' bindtap="click" data-index="{{index}}" data-text='{{item}}'>{{item}} | ||
| </view> | ||
| </block> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.