582 feat introduced max node attempts configuration#583
Open
jlopez-ikono wants to merge 5 commits into
Open
Conversation
…entry counter logic to limit node reentry attempts
… fetching from config each time
…ty method and removed redundant function
fduqueg
reviewed
Jul 10, 2026
fduqueg
reviewed
Jul 10, 2026
Comment on lines
+233
to
+234
| if room.route.node_id == executed_node_id and room.route.state == RouteState.INPUT: | ||
| room.set_node_var(reentry_node_attempts=room.reentry_node_attempts + 1) |
fduqueg
approved these changes
Jul 10, 2026
…turning early if the route state is not INPUT
…proved node reentry handling
fduqueg
reviewed
Jul 15, 2026
| from ..config import Config | ||
| from ..room import Room | ||
| from ..utils.flags import RenderFlags | ||
| from ..utils.types import Scopes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.