Skip to content

Comments

Add FCC Config#171

Open
Victor-Schwan wants to merge 7 commits intoiLCSoft:masterfrom
Victor-Schwan:add-FCC-Config
Open

Add FCC Config#171
Victor-Schwan wants to merge 7 commits intoiLCSoft:masterfrom
Victor-Schwan:add-FCC-Config

Conversation

@Victor-Schwan
Copy link
Contributor

BEGINRELEASENOTES

  • Add Config files for different CM energies of FCC-ee
  • Only *.cfg and no *.xml for single-source-of-truth
  • simlink ILC files to old folder to avoid changing ILDReconstruction.py for the moment

ENDRELEASENOTES

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the symlinks? I think we could just change the usage in the corresponding steering / option files.

I would also keep the ParametersUnknown.* files in the top level Config folder instead of placing copies into the ILC and FCC-ee folders.

@tmadlener tmadlener marked this pull request as ready for review February 16, 2026 09:50
@tmadlener
Copy link
Contributor

CI failures are unrelated to the changes here. They are tracked in: key4hep/key4hep-spack#836

@Victor-Schwan
Copy link
Contributor Author

Do we need the symlinks? I think we could just change the usage in the corresponding steering / option files.

I would also keep the ParametersUnknown.* files in the top level Config folder instead of placing copies into the ILC and FCC-ee folders.

The symlinks are just a hot fix until the corresponding steering / option files are changed. I have already changed ILDReconstruction.py (I only use this) and after changing the remaining steering / option files, we can remove the symlinks.

Ok. I did move the ParametersUnknown.* files as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants