Skip to content

Make sure to also put pre-generated headers into include directories#182

Merged
tmadlener merged 2 commits intoiLCSoft:masterfrom
tmadlener:target-include-dirs
Dec 6, 2023
Merged

Make sure to also put pre-generated headers into include directories#182
tmadlener merged 2 commits intoiLCSoft:masterfrom
tmadlener:target-include-dirs

Conversation

@tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Also put pre-generated headers into include directories of LCIO target to make in-source builds (e.g. via. CMake's FetchContent) possible.

ENDRELEASENOTES

@arummler can you check whether this fixes the issues you described in #180?

@arummler
Copy link
Contributor

arummler commented Dec 5, 2023

There is one typo: "PROJECt" --> "PROJECT". If you fix that one it will work for me. Thanks.

@tmadlener
Copy link
Contributor Author

Thanks for checking. Waiting for CI to run through before merging.

@tmadlener tmadlener merged commit 2520350 into iLCSoft:master Dec 6, 2023
@tmadlener tmadlener deleted the target-include-dirs branch December 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments