Apple Silicon support (replace node-sass; enable node 18; upgrade storybook) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough bentley/react-scripts issue
Contributor
Author
|
@raplemie We'll need to test this out on Windows - I actually have no idea what state the storybook was in as I couldn't run it prior to these upgrades. (I can do it in a VM, no worries) |
| import { BrowserAuthorizationClient } from "@itwin/browser-authorization"; | ||
|
|
||
| BrowserAuthorizationCallbackHandler.handleSigninCallback(window.location.toString()).catch(console.log); | ||
| BrowserAuthorizationClient.handleSignInCallback().catch(console.log); |
Member
There was a problem hiding this comment.
Was talking with @raplemie and he was wondering if we need the addon or if we can get away without it and put the auth directly in the app. @ben-polinsky thoughts?
Contributor
Author
There was a problem hiding this comment.
Have to get back to this. Yeah I could look into that when I have a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path toward M1 Mac support:
Replace node-sass with sass
node-sass is deprecated and does not have support for apple silicon.
Storybook 6 also had dependencies which caused builds to fail on apple silicon. Thus node 18 and the upgrade Storybook 7.