This repository was archived by the owner on Feb 12, 2019. It is now read-only.
Comments #57
Open
Comments #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Jul 26, 2018
| value = "# " + value.slice(1, value.length); | ||
| } | ||
|
|
||
| return value; |
There was a problem hiding this comment.
How about removing the leading # of the comment text, then stripping leading & trailing whitespace so there’s consistent spacing?
Collaborator
|
@iamsolankiamit Is there anything I can help with here? 👍 |
Owner
Author
|
@AlanFoster Due to personal and professional commitments I was not able to give this enough attention and probably won't be able to for at least a month. That said, to complete the comments and grouping part, we need to replicate the implementation done for alias, arrays, etc to all the tokens/sexps. I'd be glad if you or someone from the community takes this ahead. Thanks, |
Owner
Author
|
We can merge this into master and then can be taken ahead from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.