-
Notifications
You must be signed in to change notification settings - Fork 82
Improved TOC header navigation for headers nested in tabs #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview of modified files: no change to preview. |
reithor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - tested on chrome and opera.
One thing though:
May be it's semantically not 100% correct to use tabs for LTS updates in https://doc.ibexa.co/en/5.0/update_and_migration/from_4.6/update_from_4.6/#lts-updates
Tabs are fine when having a group of very similar things (like MySql|Postgres Headless|Experience|Commerce). Probably it is better to avoid Tabs for LTS Updates ?
|
The idea I had is that it's easier to quickly check the tab for each LTS update you use - having it without tabs would mean that you read through every LTS update section even when not using it. But it's something we can discuss within the team |
seems not related to the new script - current status is already not 100% accurate - https://doc.ibexa.co/en/5.0/update_and_migration/from_4.6/update_from_4.6/#__tabbed_9_1 |
adriendupuis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to find the right tab for any section's heading

Target: 4.6, 5.0
Issue reported on Slack.
Disclaimer: code is heavily AI-generated, but I've reviewed and tested it dilligently - hope I didn't miss anything.
One test scenario:
go to https://ez-systems-developer-documentation--3010.com.readthedocs.build/en/3010/update_and_migration/from_4.6/update_from_4.6/ and click on the headers (in the right TOC) in the "LTS updates" section - the tab should be activated automatically.