[minor] Fix MAF configuration task execution logic for accurate handling of maf.enabled values #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://jsw.ibm.com/browse/MASCORE-10416
https://jsw.ibm.com/browse/MASCORE-10419
Description
Previously, the execution logic for gitops-maf-config and gitops-deprovision-maf-app-config tasks did not correctly handle scenarios where maf.enabled was set to false.
Changes made:
gitops-deprovision-maf-app-config task : Updated condition to in [""] so it executes only when maf_enabled is empty or undefined.
Test Results
Verified by passing different values for maf.enabled:
true → config task executed
undefined → deprovision task executed
No automated tests impacted.