Skip to content

Conversation

@boonware
Copy link
Contributor

@boonware boonware commented Sep 3, 2025

Issue

MASAIB-1321

Related

ibm-mas/cli#1763

Description

Add a new function to list AI Service instances in the cluster by checking for all AIServiceApp CRs.

@boonware boonware changed the title [wip] update pipeline for AI Service [patch] function to list AI Service instances Sep 5, 2025
@boonware boonware marked this pull request as ready for review September 5, 2025 10:33
@boonware boonware changed the title [patch] function to list AI Service instances [minor] function to list AI Service instances Sep 5, 2025
karol-czarnecki
karol-czarnecki previously approved these changes Sep 5, 2025
Copy link
Contributor

@durera durera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we eliminate the duplicate code, e.g.

def listAiServiceInstances(dynClient: DynamicClient) -> list:
  # This just calls listInstances()
def listMasInstances(dynClient: DynamicClient) -> list:
  # This just calls listInstances()
def listInstances(dynClient: DynamicClient, apiVersion: str, kind: str) -> list:
  # This has the implementation

@boonware
Copy link
Contributor Author

boonware commented Sep 8, 2025

Can we eliminate the duplicate code, e.g.

def listAiServiceInstances(dynClient: DynamicClient) -> list:
  # This just calls listInstances()
def listMasInstances(dynClient: DynamicClient) -> list:
  # This just calls listInstances()
def listInstances(dynClient: DynamicClient, apiVersion: str, kind: str) -> list:
  # This has the implementation

Code refactored as suggested.

@boonware boonware requested a review from durera September 8, 2025 12:50
@durera durera added this pull request to the merge queue Sep 8, 2025
Merged via the queue into stable with commit 4cfbabb Sep 8, 2025
2 checks passed
@durera durera deleted the 1321 branch September 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants