Skip to content

Conversation

@terc1997
Copy link
Contributor

@terc1997 terc1997 commented Dec 10, 2025

Changes

  • Create function notifiyProvisionRoks() that has the same function as notifyProvisionFyre(), however it loads information for ROKS.
  • Created an additional parameter --add-details that loads another section to the message block. This was implemented specifically for ROKS, since in our Personal FVT it will require additional messaging with BUSINESS_JUSTIFICATION.
  • Add broadcast function, which allows SLACK_CHANNEL to be a string with multiple channels, like SLACK_CHANNEL=channel1,channel2,channel3. All of them will receive the message.
  • Fix some small code smells

Tests

The screenshot below shows the test with and without add-details flag.
image

@terc1997 terc1997 changed the title Mascore 11171 [patch] add notification for roks provisioning Dec 10, 2025
@terc1997 terc1997 marked this pull request as ready for review December 10, 2025 22:10
@terc1997 terc1997 requested a review from a team as a code owner December 10, 2025 22:10
@terc1997 terc1997 requested a review from durera December 15, 2025 13:01
@durera durera changed the title [patch] add notification for roks provisioning [patch] Add Slack notification for ROKS provisioning Dec 15, 2025
@durera durera changed the title [patch] Add Slack notification for ROKS provisioning [minor] Add Slack notification for ROKS provisioning Dec 15, 2025
@durera durera added this pull request to the merge queue Dec 15, 2025
Merged via the queue into stable with commit 25b9131 Dec 15, 2025
2 checks passed
@durera durera deleted the mascore-11171 branch December 15, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants