Skip to content

[patch] Remove deprecated install_arcgis parameter : MASCORE-10768 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alfishan merged 2 commits into from
Jan 21, 2026
Merged

[patch] Remove deprecated install_arcgis parameter : MASCORE-10768 #172

Alfishan merged 2 commits into from
Jan 21, 2026

Conversation

@Alfishan
Copy link
Contributor

@Alfishan Alfishan commented Jan 20, 2026

Summary

Removes the deprecated install_arcgis parameter from the pipeline run template and updates the conditional logic to use mas_arcgis_channel instead.

Changes

  • Removed install_arcgis parameter from pipelinerun template
  • Updated conditional logic to check mas_arcgis_channel directly
  • Simplified ArcGIS installation trigger logic

Related Issues

  • MASCORE-10768: Update dependencies on Tekton for ArcGIS installation
  • MASCORE-10767: Update installation of ArcGIS on CLI
  • MASCORE-10766: Update ansible-devops to detect Manage and MREF during installation of ArcGIS

Related PRs

Files Modified

  • src/mas/devops/templates/pipelinerun-install.yml.j2 - Removed deprecated parameter and updated conditional logic

@Alfishan
Squashed commit of the following:
8469d57 
commit 8f95023
Author: Mahammad Alfishan Salar <Alfishan@gmail.com>
Date:   Tue Jan 13 18:32:22 2026 +0530

    [patch] Update ArcGIS installation condition

    - Updated piperun-install template to trigger installation when arcgis channel is set as per new cli changes.
@Alfishan Alfishan changed the title [patch] Remove deprecated install_arcgis parameter [patch] Remove deprecated install_arcgis parameter : MASCORE-10768 Jan 20, 2026
@Alfishan Alfishan mentioned this pull request Jan 20, 2026
Merged
@Alfishan Alfishan marked this pull request as ready for review January 20, 2026 08:48
@Alfishan Alfishan requested a review from a team as a code owner January 20, 2026 08:48
@Alfishan Alfishan requested a review from terc1997 January 20, 2026 08:48
durera
durera approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@durera durera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alfishan Alfishan added this pull request to the merge queue Jan 21, 2026
Merged via the queue into stable with commit cfa5a3c Jan 21, 2026
3 checks passed
@Alfishan Alfishan deleted the masr-6128-arcgis branch January 21, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durera durera durera approved these changes

@terc1997 terc1997 Awaiting requested review from terc1997

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alfishan @durera