[major] Replace ICSP with IDMS #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2024
durera
requested review from
JonahLuckett,
alequint,
andrercm,
leo-miran,
sanjayprab,
terenceq and
whitfiea
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have dropped support for OpenShift Container Platform 4.12 we are ready to remove support for the deprecated ImageContentSourcePolicy (ICSP) and replace it with the new ImageDigestMirrorSet (IDMS).
The
isAirgapInstall()function will now only identify a cluster as configured for airgap install mode if one (or more) MAS IDMS are present on the cluster, hence this is a major version bump (breaking change).See also: