Skip to content

Conversation

@marlewe
Copy link
Contributor

@marlewe marlewe commented Dec 15, 2023

The getLink(...) api call and its tests were removed.

Close #148

@RKrahl RKrahl added the remove feature Proposal to remove some feature label Dec 15, 2023
@RKrahl RKrahl added this to the 3.0.0 milestone Dec 15, 2023
Copy link
Member

@RKrahl RKrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still found a few residues of this feature and related data structures in the code. Most prominently: you should also remove the deletion of old links in the Tidier.

@RKrahl RKrahl self-requested a review December 18, 2023 14:19
Copy link
Member

@RKrahl RKrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove feature Proposal to remove some feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop getLink API call

3 participants