Visualization improvements#33
Open
NawaKhai wants to merge 7 commits into
Open
Conversation
Visualization Model and its accompanying files.
Geometry files for a Blended-Wing-Body configuration
Fixed the bug when a propulsion architecture has only 1 thrust source that doesn't allow for all the power source connections to be made properly to that one thrust source.
Added TestGeometry.m to FAST repo which allows users to quickly view geometries in standalone mode
Added the PropArchTest file which allows users to rapidly view propulsion architectures into the FAST repository
prmoko
requested changes
Jul 30, 2024
prmoko
left a comment
prmoko
left a comment
Collaborator
There was a problem hiding this comment.
Overall, most of the code looks great! The visuals look great too (as always)! There's just a few fixes that need to be made and a couple other things to address:
- LM100JTrussBraced.m doesn't exist, so the case in TestGeometry.m that calls that file fails.
- Please check and fix the formatting of BWB.m; refer to Contributions.m (or .md) file for details on what to fix.
- Should the block comments for some components in SUSAN.m be uncommented (or removed)?
- In Line 359 of PropulsionArchitecture.m, the variable isn't used. Can this be removed, or will the variable be used at a later date for spacing the lines vertically?
- In PropArchTest.m, can the block-commented propulsion architectures be removed (or fixed to look like the other propulsion architectures tested)?
- Additionally, it's difficult to understand what's going on in PropArchTest(8). I like that you're using a unique combination of matrix inputs (very clever!), but maybe there's a way to simplify this test case so we can better see what is going on.
- Lastly, what is PropArchTest(5) trying to show? I noticed that one of the energy sources is not connected to any components in the propulsion architecture.
Otherwise, everything looks good. Feel free to address these comments and then we can get this content merged.
Updated how the propulsion architecture connections are printed to the command line.
Fixed typos in the printouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transferring public EAP Visualization work to the FAST repository