Add ability response body and response content type#18
Open
TheSmartnik wants to merge 2 commits intoifad:masterfrom
Open
Add ability response body and response content type#18TheSmartnik wants to merge 2 commits intoifad:masterfrom
TheSmartnik wants to merge 2 commits intoifad:masterfrom
Conversation
Author
|
@vjt could you take a look, please? |
vjt
reviewed
Mar 23, 2020
Contributor
vjt
left a comment
vjt
left a comment
There was a problem hiding this comment.
This looks reasonable and good, thank you.
Just a small change requested and I'll merge.
| VirusStatusCode: 418, | ||
| ContentMemoryThreshold: 1024 * 1024, | ||
| VirusResponseBody: "", | ||
| VirusResponseContentType: "text/plain; charset=utf-8", |
Contributor
There was a problem hiding this comment.
Can you please set a default here, and...
|
|
||
| if len(c.VirusResponseBody) > 0 { | ||
| w.Write([]byte(c.VirusResponseBody)) | ||
| } else { |
Contributor
There was a problem hiding this comment.
...remove this if from here, given that there will always be a response body defined.
Contributor
|
ps. sorry for the delay... |
vjt
reviewed
Mar 23, 2020
| w.Write([]byte(c.VirusResponseBody)) | ||
| } else { | ||
| w.Write([]byte(fmt.Sprintf("File %s has a virus!", filename))) | ||
| } |
Contributor
There was a problem hiding this comment.
Yes we are losing the filename in the response - however it's not a big loss :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for the clammit!
I thought that it could be useful to specify custom response body and content-type. For example, if backend has a convention for errors with specified body and content-type frontend wouldn't have to handle 418 as a special case.
I'm not familiar wit Go, so apologies for any apparent mistake, would love to fix them