[Migration] Upgrade to new version of Instagram APIs by vineetvk01 · Pull Request #1250 · igdmapps/igdm

vineetvk01 · 2020-03-11T18:07:07Z

Tasks:

- Updating to the latest "instagram-private-api" repository (migration)
- Updating Two-Factor-Authentication (fix)
After entering the code in the OTP window, still login was not happening
- Send Image in chat (fix)
We were not able to send .jpg images in the chat previously. Fixed the issue
- Chat gets stuck while loading old messages when reaches last message (fix)
When we go to the very top of the chat, when there is no more old messages, the chat seems to be stuck there sometimes
- Limiting image height in chat view (update)
The image renders with the original size, which captures a lot of space of the chat screen, limited the height to 300px for better chat view

Closes: #1245 , #1244, #1243 , #1241

ifedapoolarewaju

Nice work Vineet! 👍 I dropped some comments here and there. Also this branch has diverged from master, so it can't be merged without conflicts. Can you maybe rebase with master in order to fix this?

ifedapoolarewaju · 2020-03-29T10:09:05Z

main/instagram.js

-      }
-      session = new Client.Session(device, storage);
+    igClient.state.serialize().then((cookies)=>{
+      delete cookies.constants;


what's the implication of this deletion? 🤔

this deletes the version info. So, it always use the version provided by the library.
Suggested here :
https://github.com/dilame/instagram-private-api/blob/master/examples/session.example.ts

got it 👍

ifedapoolarewaju · 2020-03-29T10:32:04Z

main/instagram.js

-    const feed = new Client.Feed.Inbox(session, 10);
-    feed.all().then(resolve).catch(reject);
+exports.startCheckpoint = () => {
+  //return Client.Web.Challenge.resolve(error, 'email');


did you mean to delete this?

Yes. Will remove the comment. Kept for a doubt which resolved now. 👍

ifedapoolarewaju · 2020-03-29T10:48:23Z

main/instagram.js

+exports.sendNewChatMessage = function (message, recipients) {
  return new Promise((resolve, reject) => {
-    Client.Thread.configureText(session, recipients, message).then(resolve).catch(reject);
+    const directThread = igClient.entity.directThread(recipients);


The sendNewChatMessage function was originally meant for starting new conversations (where there's no threadId/chatId yet). Looking at the instagram private api code, it seems the directThread function only accepts threadIds and not usernames. Are we certain that this function still works for starting new conversations? 🤔

Yes, I have tested the APIs. If we pass Array of recipients then it will start a new conversation. else if its an string of threadID, it will send to thread.
instagram.sendNewChatMessage(data.message, data.users)

ifedapoolarewaju · 2020-03-29T11:21:48Z

main/main.js

    let message = 'An unknown error occurred.';
-    if (error.message) {
-      message = error.message;
+    if (error.text) {


this if (...) check is redundant, no? 🤔

ifedapoolarewaju · 2020-03-29T11:51:41Z

main/main.js

-  instagram.getUser(session, userId).then((user) => {
-    mainWindow.webContents.send('getDisplayPictureUrl', { userId: userId, url: user._params.profilePicUrl });
+  instagram.getUser(userId).then((user) => {
+    mainWindow.webContents.send('getDisplayPictureUrl', { userId: userId, url: user.profile_pic_url });


is this profile_pic also possible available in the authenticatedUser object? 🤔

Yes, should be. We can remove this method, Agree. checking 💯

I just checked, This profile_pic is fetched on the base of userId which is rendered in renderMessageReactions. So, authenticatedUser only consists of the loggedIn user's info.

ah! that's right

ifedapoolarewaju · 2020-03-29T11:56:50Z

main/utils.js

+  if (canUseFileStorage()) {
+    const storagePath = buildAndGetStoragePath();
+    const filePath = `${username}.json`;
+    fs.writeFileSync(storagePath+'/'+filePath, JSON.stringify(cookies));


Suggested change

fs.writeFileSync(storagePath+'/'+filePath, JSON.stringify(cookies));

fs.writeFileSync(`${storagePath}/${filePath}`, JSON.stringify(cookies));

ifedapoolarewaju · 2020-03-29T12:01:08Z

main/utils.js

-    storage = new Client.CookieMemoryStorage();
-  }
-
+    if (filePath) storage = fs.readFileSync(`${buildAndGetStoragePath()}/${filePath}`, 'utf8');


are we supposed to JSON.parse(...) this data before sending it back?

also, based on the new behaviour of this function, I think we should rename it to ~~getCookieStorage~~ geStoredCookie

The JSON is deserializing in,
instagram.js Line 19

function loadCookieInSession () { return new Promise((resolve, reject) => { const savedCookie = utils.getStoredCookie(); if (savedCookie) { igClient.state.deserialize(savedCookie).then(() => { resolve(true); }).catch(reject); } else { reject('No session saved'); } }); }

So, we might need not to parse.

ifedapoolarewaju · 2020-03-29T14:17:15Z

browser/js/renderers.js

+  let post = message.media_share;
+  let img = '';
+  if (post.image_versions2) {
+    img = dom(`<img style='max-height:400px;' src="${post.image_versions2.candidates[0].url}">`);


can this style='max-height:400px;' be handled in css instead? 🤔 Same for the other cases in this PR

Yes. Sounds Perfect. 💯

ifedapoolarewaju · 2020-03-29T14:27:37Z

browser/js/renderers.js

 }

-function renderChat (chat_, loadingMore) {
+function renderChat (chat_) {


why are we dropping the loadingMore flag here? 🤔

Yes, In the first API call for fetching chat-lists we are getting 10 messages for each chat in the List. Previously, We used to get One message in each chat, and we were loading more.

Provide your suggestion should we keep loading ? 🔑

hmm, I see what you mean. I'd say we don't need it anymore indeed then.

vineetvk01 · 2020-04-02T14:26:29Z

main/instagram.js

-    Client.Thread.getById(session, chatId).then((thread)=>{
-      thread.hide().then(resolve);
+    chatsFeed.items().then((chats)=>{
+      const thread = chats.find(chat => chat.thread_id === chatId);


Trying to optimize this O(n) of extra computation. This will delay the chat to render every time we de-queue a sent message in front-end, which we merged in previous PR.

ifedapoolarewaju · 2020-04-03T08:20:27Z

browser/js/funcs.js

  let queue = window.messageInQueue[chatId];
+  const lb = queue.length;
  queue = queue.filter((messageQueued) => messageQueued.trackerKey !== trackerKey);
+  const la = queue.length;


is this value needed for anything? Also the one above?

optimized-get-chat

ifedapoolarewaju · 2020-04-03T18:13:13Z

thank you for the work Vineet! ❤️

ghost · 2020-04-03T18:14:54Z

can I add my thanks here as well? <3 @vineetvk01
Waiting anxiously for #1266 now! :)

vineetvk01 changed the title ~~[WIP] [Migration] Upgrade of Instagram API~~ [WIP] [Migration] Upgrade to new version of Instagram APIs Mar 11, 2020

vineetvk01 force-pushed the migrateapi branch 4 times, most recently from 4c224fd to b007922 Compare March 21, 2020 17:07

vineetvk01 changed the title ~~[WIP] [Migration] Upgrade to new version of Instagram APIs~~ [WIP] [In-Testing] [Migration] Upgrade to new version of Instagram APIs Mar 21, 2020

vineetvk01 changed the title ~~[WIP] [In-Testing] [Migration] Upgrade to new version of Instagram APIs~~ [Migration] Upgrade to new version of Instagram APIs Mar 24, 2020

vineetvk01 force-pushed the migrateapi branch from b007922 to ae406fe Compare March 24, 2020 14:11

vineetvk01 mentioned this pull request Mar 25, 2020

[WIP] [Feat] Like a message in DM(Chat) #1266

Open

ifedapoolarewaju reviewed Mar 29, 2020

View reviewed changes

vineetvk01 commented Apr 2, 2020

View reviewed changes

vineetvk01 force-pushed the migrateapi branch from ae406fe to 705db7e Compare April 2, 2020 15:14

vineetvk01 changed the title ~~[Migration] Upgrade to new version of Instagram APIs~~ [WIP] [Migration] Upgrade to new version of Instagram APIs Apr 2, 2020

vineetvk01 changed the title ~~[WIP] [Migration] Upgrade to new version of Instagram APIs~~ [Migration] Upgrade to new version of Instagram APIs Apr 2, 2020

ifedapoolarewaju reviewed Apr 3, 2020

View reviewed changes

intsgram-private-api-migration

5ceedd0

optimized-get-chat

vineetvk01 force-pushed the migrateapi branch from 705db7e to 5ceedd0 Compare April 3, 2020 13:04

ifedapoolarewaju merged commit 86f4ae6 into igdmapps:master Apr 3, 2020

	fs.writeFileSync(storagePath+'/'+filePath, JSON.stringify(cookies));
	fs.writeFileSync(`${storagePath}/${filePath}`, JSON.stringify(cookies));

Comments

Conversation

vineetvk01 commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tasks:

Uh oh!

ifedapoolarewaju left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ifedapoolarewaju commented Apr 3, 2020

Uh oh!

ghost commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vineetvk01 commented Mar 11, 2020 •

edited

Loading