Replace deprecated np.in1d with np.isin#1127
Merged
andreicuceu merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
Co-authored-by: andreicuceu <28951059+andreicuceu@users.noreply.github.com> Agent-Logs-Url: https://github.com/igmhub/picca/sessions/a84f61d6-2f15-418c-8701-3552c51ed26b
Copilot
AI
changed the title
[WIP] Refactor code to use np.isin instead of np.in1d
Replace deprecated Mar 23, 2026
np.in1d with np.isin
andreicuceu
approved these changes
Mar 23, 2026
HiramHerrera
approved these changes
Mar 23, 2026
Collaborator
HiramHerrera
left a comment
There was a problem hiding this comment.
These changes look inoffensive to me and correctly address the deprecation of np.in1d in NumPy > 1.24.
Everything looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy.in1dwas deprecated in NumPy 1.24 and removed in recent versions, causing test failures. Replace all usages with the equivalentnumpy.isin.Changes
py/picca/,py/picca/bin/,py/picca/pk1d/,py/picca/delta_extraction/, andtutorials/np.isinis a drop-in replacement — identical signature and return behavior for all use cases here.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.