Skip to content

OF-2549: Fix JavaScript error and improve UX in MUC Create Permission page #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MilanTyagi2004 wants to merge 3 commits into
base: main
Choose a base branch
from
+37 −11
Open

OF-2549: Fix JavaScript error and improve UX in MUC Create Permission page #3239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af80d38
OF-2549: Fix MUC permission persistence and improve UX
MilanTyagi2004 Apr 2, 2026
b675c64
OF-2549: Fix 'All registered users' checkbox cleared on Save Settings
MilanTyagi2004 May 7, 2026
c828328
OF-2549: Fix id for tapping on the non-default option
Fishbowler May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 37 additions & 11 deletions xmppserver/src/main/webapp/muc-create-permission.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<%@ page contentType="text/html; charset=UTF-8" %>
<%--
-
- Copyright (C) 2004-2008 Jive Software, 2017-2025 Ignite Realtime Foundation. All rights reserved.
- Copyright (C) 2004-2008 Jive Software, 2017-2026 Ignite Realtime Foundation. All rights reserved.
-
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -86,6 +86,7 @@
}
else {
mucService.setRoomCreationRestricted(true);
mucService.setAllRegisteredUsersAllowedToCreate(allowAllRegisteredUsers);
// Log the event
webManager.logEvent("set MUC room creation to not restricted for service "+mucname, null);
response.sendRedirect("muc-create-permission.jsp?success=true&mucname="+URLEncoder.encode(mucname, StandardCharsets.UTF_8));
Expand Down Expand Up @@ -126,6 +127,7 @@
if (add) {
mucService.addUsersAllowedToCreate(allowedJIDs);
mucService.setAllRegisteredUsersAllowedToCreate(allowAllRegisteredUsers);
mucService.setRoomCreationRestricted(true);
// Log the event
webManager.logEvent("updated MUC room creation permissions for service "+mucname, null);
response.sendRedirect("muc-create-permission.jsp?addsuccess=true&mucname="+URLEncoder.encode(mucname, StandardCharsets.UTF_8));
Expand All @@ -151,6 +153,29 @@
<meta name="subPageID" content="muc-perms"/>
<meta name="extraParams" content="<%= "mucname="+URLEncoder.encode(mucname, StandardCharsets.UTF_8) %>"/>
<meta name="helpPage" content="set_group_chat_room_creation_permissions.html"/>
<script>
function toggleAllowedUsers() {
const isRestricted = document.getElementById('restrictedPermissionsRadio').checked;
const container = document.getElementById('allowedUsersContainer');
const input = document.getElementById('userJIDtf');

if (isRestricted) {
container.style.display = 'block';
if (input) {
input.focus();
}
} else {
container.style.display = 'none';
}
}
function syncAllowAllRegistered() {
const cb = document.getElementById('allowAllRegisteredUsers');
const hidden = document.getElementById('allowAllRegisteredUsersHidden');
if (cb && hidden) {
hidden.value = cb.checked ? 'true' : 'false';
}
}
</script>
</head>
<body>

Expand Down Expand Up @@ -193,6 +218,7 @@
<form action="muc-create-permission.jsp?save" method="post">
<input type="hidden" name="csrf" value="${csrf}">
<input type="hidden" name="mucname" value="<%= StringUtils.escapeForXML(mucname) %>" />
<input type="hidden" name="allowAllRegisteredUsers" id="allowAllRegisteredUsersHidden" value="<%= mucService.isAllRegisteredUsersAllowedToCreate() ? "true" : "false" %>" />
<div class="jive-contentBoxHeader">
<fmt:message key="muc.create.permission.policy" />
</div>
Expand All @@ -202,6 +228,7 @@
<tr>
<td style="width: 1%">
<input type="radio" name="openPerms" value="true" id="rb01"
onchange="toggleAllowedUsers()"
<%= ((!mucService.isRoomCreationRestricted()) ? "checked" : "") %>>
</td>
<td>
Expand All @@ -210,12 +237,12 @@
</tr>
<tr>
<td style="width: 1%">
<input type="radio" name="openPerms" value="false" id="rb02"
onfocus="this.form.userJID.focus();"
<input type="radio" name="openPerms" value="false" id="restrictedPermissionsRadio"
onchange="toggleAllowedUsers()"
<%= ((mucService.isRoomCreationRestricted()) ? "checked" : "") %>>
Comment thread
Fishbowler marked this conversation as resolved.
</td>
<td>
<label for="rb02"><fmt:message key="muc.create.permission.specific_created" /></label>
<label for="restrictedPermissionsRadio"><fmt:message key="muc.create.permission.specific_created" /></label>
</td>
</tr>
</tbody>
Expand All @@ -227,8 +254,7 @@

<br>


<% if (mucService.isRoomCreationRestricted()) { %>
<div id="allowedUsersContainer" style="display: <%= (mucService.isRoomCreationRestricted() ? "block" : "none") %>">
<!-- BEGIN 'Allowed Users' -->
<form action="muc-create-permission.jsp?add" method="post">
<input type="hidden" name="csrf" value="${csrf}">
Expand All @@ -238,13 +264,13 @@
</div>
<div class="jive-contentBox">
<p>
<input type="checkbox" id="allowAllRegisteredUsers" name="allowAllRegisteredUsers" <%=mucService.isAllRegisteredUsersAllowedToCreate()?"checked":""%> onChange="this.form.submit()">
<input type="checkbox" id="allowAllRegisteredUsers" name="allowAllRegisteredUsers" onchange="syncAllowAllRegistered()" <%=mucService.isAllRegisteredUsersAllowedToCreate()?"checked":""%>>
<label for="allowAllRegisteredUsers"><fmt:message key="muc.create.permission.allow_registered" /></label>
</p>
<p>
<label for="groupJIDs"><fmt:message key="muc.create.permission.add_group" /></label><br/>
<select name="groupNames" size="6" multiple style="width:400px;font-family:verdana,arial,helvetica,sans-serif;font-size:8pt;"
onclick="this.form.openPerms[1].checked=true;" id="groupJIDs">
id="groupJIDs">
<% for (Group g : webManager.getGroupManager().getGroups()) { %>
<option value="<%= URLEncoder.encode(g.getName(), StandardCharsets.UTF_8) %>"
<%= (StringUtils.contains(groupNames, g.getName()) ? "selected" : "") %>
Expand All @@ -254,8 +280,8 @@
</p>
<p>
<label for="userJIDtf"><fmt:message key="muc.create.permission.add_jid" /></label>
<input type="text" name="userJID" size="30" maxlength="100" value="<%= (userJID != null ? userJID : "") %>"
onclick="this.form.openPerms[1].checked=true;" id="userJIDtf">
<input type="text" name="userJID" size="30" maxlength="100" value="<%= StringUtils.escapeForXML(userJID != null ? userJID : "") %>"
id="userJIDtf">
<input type="submit" value="Add">
</p>

Expand Down Expand Up @@ -308,7 +334,7 @@
</form>
<!-- END 'Allowed Users' -->

<% } %>
</div>


</body>
Expand Down
Loading