Fix minor issues#56
Conversation
Bumps commons-fileupload:commons-fileupload from 1.5 to 1.6.0. --- updated-dependencies: - dependency-name: commons-fileupload:commons-fileupload dependency-version: 1.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Of course, now I see that it doesn't compile... :) |
|
Sorry, I squashed wrongly. I'll recheck tomorrow |
|
Sorry for the delay. I wanted to add an ability to download .deb and .rpm, but don't have a time anymore. I fixed that compile error. Also I added aTalk and Kaidan to clients list |
There was a problem hiding this comment.
Pull request overview
This PR updates the Client Control plugin to refresh client metadata (including permitted clients UI assets), improve Spark updater UX, and modernize a dependency/versioning footprint.
Changes:
- Fix Spark Version form selection logic for macOS and Linux builds.
- Refresh permitted clients list (new client entries + icons, updated URLs).
- Bump plugin/dependency versions and apply various small Java/Javadoc cleanup changes (e.g.,
@Override, Javadoc tag updates).
Reviewed changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/spark-form.jsp | Fixes client build selection checks for macOS/Linux. |
| src/web/permitted-clients.jsp | Updates permitted client enumeration, URLs, and icon references. |
| src/web/images/client-icon_atalk.png | Adds icon asset for aTalk. |
| src/web/images/client-icon_conversations.png | Adds icon asset for Conversations. |
| src/web/images/client-icon_gajim.png | Adds icon asset for Gajim. |
| src/web/images/client-icon_kaidan.png | Adds icon asset for Kaidan. |
| src/java/org/jivesoftware/openfire/plugin/spark/TaskEngine.java | Javadoc HTML tag modernization (<tt> → <code>). |
| src/java/org/jivesoftware/openfire/plugin/spark/SparkUtil.java | Removes unused legacy utility class. |
| src/java/org/jivesoftware/openfire/plugin/spark/SparkManager.java | Adds @Override annotations for interface implementations. |
| src/java/org/jivesoftware/openfire/plugin/spark/manager/SparkVersionManager.java | Improves error responses (adds type/text) and minor Javadoc formatting. |
| src/java/org/jivesoftware/openfire/plugin/spark/manager/SparkDownloadServlet.java | Updates Spark link and fixes spelling in a comment. |
| src/java/org/jivesoftware/openfire/plugin/ClientControlPlugin.java | Adds @Override annotations and minor formatting cleanup. |
| pom.xml | Bumps plugin version and commons-fileupload dependency version. |
| changelog.html | Adds a 2.2.0 entry describing the updates in this release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
rebased |
|
Thank you! |
No description provided.