Migrate from RxJava2 to RxJava3 for the whole project and migrate to AndroidX for sample app#152
Open
mmBs wants to merge 4 commits intoigreenwood:masterfrom
Open
Migrate from RxJava2 to RxJava3 for the whole project and migrate to AndroidX for sample app#152mmBs wants to merge 4 commits intoigreenwood:masterfrom
mmBs wants to merge 4 commits intoigreenwood:masterfrom
Conversation
With bump of compileSdk, build tools, targetSdk and version of the code. Also, fix the findConventions taks and replace << with doLast.
When the library was updated to RxJava3, it was required to refresh the sample as well. The refactor consists of: - bumping comple, target sdk and build tools - adding sourceCompatibility and targetCompatibility - refreshinng dependecies for RxJava (2 --> 3) - refreshing dependencies for PermissionsDispatcher and RxPermissions - adding dependencies for AndroidX (annotation and app compat) - removing some deprecated methods (like getFragmentManager()) - adapting the code to new APIs from RxPermissions and PermissionsDispatcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I migrated the lib to RxJava3 as RxJava2 will be deprecated soon (end of support is the last day of Dec 2020).
I tested the lib on the sample app which I also adapted to the newest dependencies (AndroidX etc.)
I haven't rewritten it to Kotlin but I will consider it if I have some time ;)
I hope you will find this PR helpful.
Cheers,
Michal