ext/session: check the created ID before validating it - #197
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
iliaal
force-pushed
the
fix/session-create-id-null-sid
branch
2 times, most recently
from
July 29, 2026 18:00
873c330 to
61243b1
Compare
session_create_id() passes the return value of s_create_sid() straight into s_validate_sid(). A userland create_sid() that throws makes ps_create_sid_user() return NULL, and ps_validate_sid_user() then reaches ZVAL_STR_COPY() with a NULL key. Stop the retry loop when no ID was created and propagate a pending exception instead of reporting a plain failure. The four s_create_sid() call sites in php_session_initialize() and session_regenerate_id() already test for NULL. Closes phpGH-22924
iliaal
force-pushed
the
fix/session-create-id-null-sid
branch
from
July 29, 2026 18:02
61243b1 to
f9b3c7b
Compare
Owner
Author
|
Promoted upstream as php#22924. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_create_id()hands the return value ofs_create_sid()straight tos_validate_sid(). A userlandcreate_sid()that throws makes ps_create_sid_user() return NULL, and ps_validate_sid_user() then reachesZVAL_STR_COPY()with a NULL key. Reproducer is a SessionHandler subclass whose create_sid() throws on its second call, with validateId() defined, then session_create_id() on an active session: SIGSEGV on 8.4, 8.5 and master.Every other s_create_sid() call site in ext/session already tests for NULL (php_session_initialize twice, session_regenerate_id twice, PS_READ_FUNC(mm)); this was the one that did not. It now stops the retry loop and propagates the pending exception rather than reporting a generic "Failed to create new ID", with the original throwable kept as the previous exception.