ext/session: report a rejected session cookie header - #198
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
iliaal
force-pushed
the
fix/session-cookie-header-failure
branch
from
July 29, 2026 16:47
0e73a00 to
d6c9488
Compare
php_session_send_cookie() discarded the result of sapi_add_header_ex() and always returned SUCCESS. When the SAPI refuses a Set-Cookie header carrying CR or LF, the warning it emits can reach a userland error handler that calls session_destroy(), and php_session_reset_id() then appends the released PS(id). Return what sapi_add_header_ex() reports so the caller stops before touching session state again. Closes phpGH-22923
iliaal
force-pushed
the
fix/session-cookie-header-failure
branch
from
July 29, 2026 18:02
d6c9488 to
4264db1
Compare
Owner
Author
|
Promoted upstream as php#22923. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_session_send_cookie()dropped the result ofsapi_add_header_ex()and always returned SUCCESS. When the SAPI refuses a Set-Cookie header containing CR or LF, the warning it emits can reach a userland error handler, and if that handler callssession_destroy()thenphp_session_reset_id()carries on and appends the released PS(id). Reproducer is aset_error_handler()that destroys the session,session_set_cookie_params(['path' => "/\r\nX: y"]), thensession_start(): SIGSEGV on 8.4, 8.5 and master, under both CLI and CGI.php_session_reset_id() has handled a FAILURE from the cookie call since 8.4, it just never saw one. The Set-Cookie header is otherwise built from validated parts: session.name is checked by OnUpdateName, the ID is URL encoded, and cookie_samesite is restricted to a fixed set, so cookie_path and cookie_domain are the only values that can carry CR or LF into the header today.