ext/session: reject cookie separators in cookie_path and cookie_domain - #199
Closed
iliaal wants to merge 3 commits into
Closed
ext/session: reject cookie separators in cookie_path and cookie_domain#199iliaal wants to merge 3 commits into
iliaal wants to merge 3 commits into
Conversation
Report UTF-8/UTF-16 conversion failures from Collator sort comparisons through the intl error mechanism. Previously, these paths emitted a warning and continued with an empty string. Keep the input array unchanged when sorting cannot complete, preserve the active collator state across nested sorts, and stop invoking further comparisons after a conversion failure. Co-authored-by: David CARLIER <devnexen@gmail.com>
iliaal
force-pushed
the
fix/session-cookie-attr-validation
branch
from
July 29, 2026 16:47
25abbb5 to
d44ce46
Compare
iliaal
force-pushed
the
fix/session-cookie-attr-validation
branch
from
July 29, 2026 18:00
d44ce46 to
8404a77
Compare
php_session_send_cookie() appends session.cookie_path and session.cookie_domain to the Set-Cookie header verbatim, and neither setting rejected the separators that terminate a cookie attribute. An application could therefore append its own Domain, Path, HttpOnly, Secure, or SameSite attribute through either value. Apply the character set setcookie() already enforces on its $path and $domain options. Closes phpGH-22925
iliaal
force-pushed
the
fix/session-cookie-attr-validation
branch
from
July 29, 2026 18:02
8404a77 to
54a0a18
Compare
Owner
Author
|
Promoted upstream as php#22925. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_session_send_cookie()appendssession.cookie_pathandsession.cookie_domainto the Set-Cookie header verbatim, and neither setting rejected the characters that terminate a cookie attribute, so an application can append its own Domain, Path, HttpOnly, Secure or SameSite.session_set_cookie_params(['path' => '/; Domain=evil.example'])emitsSet-Cookie: PHPSESSID=<id>; path=/; Domain=evil.example. This applies the byte setsetcookie()already enforces on its $path and $domain options, through the ini handler so that both session_set_cookie_params() and a direct ini_set() are covered.Master only, since it starts rejecting configuration that is accepted today. UPGRADING carries a note next to the existing entry about NUL bytes in the same two settings. session.cache_limiter keeps the old handler, as separators are not meaningful there.