Skip to content

Conversation

@HenkPoley
Copy link

I bumped into a PhpUnit error today when asserting the response has the correct header:

$response->assertHeader('content-type', 'text/html; charset=UTF-8');

PhpUnit error:

Header [content-type] was found, but value [text/html; charset=utf-8] does not match [text/html; charset=UTF-8].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'text/html; charset=UTF-8'
+'text/html; charset=utf-8'

[..paths omitted..]

It might be that redirect('/some/path') fairly recently changed from UTF-8 to utf-8 due to HPACK/QPACK normalisation rules. But it broke some of my tests.

In principle these HTTP headers are case-insensitive, so this change to \Illuminate\Testing\TestResponse::assertHeader() makes sense.

Let me know if you agree, or you want it fixed in another way.

I bumped into a PhpUnit error today when asserting the response has the correct header:

```php
$response->assertHeader('content-type', 'text/html; charset=UTF-8');
```

PhpUnit error:

```
Header [content-type] was found, but value [text/html; charset=utf-8] does not match [text/html; charset=UTF-8].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'text/html; charset=UTF-8'
+'text/html; charset=utf-8'

[..paths omitted..]
```

It might be that `redirect('/some/path')` fairly recently changed from UTF-8 to utf-8 due to HPACK/QPACK normalisation rules. But it broke some of my tests.

In principle these HTTP headers are case-insensitive, so this change to `\Illuminate\Testing\TestResponse::assertHeader()` makes sense.

Let me know if you agree, or you want it fixed in another way.
@HenkPoley
Copy link
Author

Ah.. I see this message appear elsewhere:

Thank you for your pull request. However, you have submitted this PR on the Illuminate organization which is a read-only sub split of laravel/framework. Please submit your PR on the https://github.com/laravel/framework repository.

Thanks!

I'll check over there.

@HenkPoley
Copy link
Author

Proper pull request here: laravel/framework#58383

@HenkPoley HenkPoley closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant