Fix hook extension case #2660
Merged
Fix hook extension case #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
197g
reviewed
Nov 25, 2025
src/io/image_reader_type.rs
Outdated
| .extension() | ||
| .filter(|ext| !ext.is_empty()) | ||
| .map(|ext| Format::Extension(ext.to_owned())); | ||
| .map(|ext| Format::Extension(ext.to_ascii_lowercase())); |
Member
There was a problem hiding this comment.
Nit: Please add a comment on the enum's variant that its contents are supposed to be normalized to ascii lowercase.
Contributor
There was a problem hiding this comment.
Instead of lower-casing here, I think it would be better to allow arbitrary casing in Format::Extension and lower-case in ImageReader::make_decoder where casing causes problems.
I'm saying this in the context of #2662 where I added a second code path that creates a Format::Extension.
Contributor
Author
There was a problem hiding this comment.
hm good point, that fits the existing pattern of ImageFormat::from_extension better. I don't want to affect that since your PR and issue 2616 might change it.
fintelia
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make integration hook extensions case-insensitive, matching built-in formats. Also added some tests to show it failing before the change; not sure if they're useful or follow standards. New to Rust and first time contributing, so any feedback is welcome!
See issue #2659